Hi Mohan,
Ack for this patch with a minor comment.
Regards, Vu
> -----Original Message-----
> From: Mohan Kanakam <mo...@hasolutions.in>
> Sent: Thursday, November 1, 2018 3:28 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
> <mo...@hasolutions.in>
> Subject: [PATCH 1/3] imm: add new test cases of API
> saImmOmSelectionObjectGet() of apitest [#2951]
>
> ---
> src/imm/apitest/management/test_saImmOmInitialize.c | 8 ++++++++
> .../apitest/management/test_saImmOmSelectionObjectGet.c | 15
> +++++++++++++++
> 2 files changed, 23 insertions(+)
>
> diff --git a/src/imm/apitest/management/test_saImmOmInitialize.c
> b/src/imm/apitest/management/test_saImmOmInitialize.c
> index 9dcfe7a..2dca5da 100644
> --- a/src/imm/apitest/management/test_saImmOmInitialize.c
> +++ b/src/imm/apitest/management/test_saImmOmInitialize.c
> @@ -303,6 +303,8 @@ void saImmOmInitialize_11(void)
>
> extern void saImmOmSelectionObjectGet_01(void);
> extern void saImmOmSelectionObjectGet_02(void);
> +extern void saImmOmSelectionObjectGet_03(void);
> +extern void saImmOmSelectionObjectGet_04(void);
> extern void saImmOmDispatch_01(void);
> extern void saImmOmDispatch_02(void);
> extern void saImmOmDispatch_03(void);
> @@ -350,6 +352,12 @@ __attribute__((constructor)) static void
> saImmOmInitialize_constructor(void)
> test_case_add(
> 1, saImmOmSelectionObjectGet_02,
> "saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE - invalid
> handle");
> + test_case_add(
> + 1, saImmOmSelectionObjectGet_03,
> + "saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE -
> uninitlized handle");
[Vu] Typo "uninitlized" ?
> + test_case_add(
> + 1, saImmOmSelectionObjectGet_04,
> + "saImmOmSelectionObjectGet - SA_AIS_ERR_BAD_HANDLE -
> finalized handle");
>
> test_case_add(1, saImmOmDispatch_01,
> "saImmOmDispatch - SA_AIS_OK SA_DISPATCH_ALL");
> diff --git
> a/src/imm/apitest/management/test_saImmOmSelectionObjectGet.c
> b/src/imm/apitest/management/test_saImmOmSelectionObjectGet.c
> index 017fd70..75b8b86 100644
> --- a/src/imm/apitest/management/test_saImmOmSelectionObjectGet.c
> +++ b/src/imm/apitest/management/test_saImmOmSelectionObjectGet.c
> @@ -35,3 +35,18 @@ void saImmOmSelectionObjectGet_02(void)
> test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> }
> +
> +void saImmOmSelectionObjectGet_03(void)
> +{
> + rc = immutil_saImmOmSelectionObjectGet(immOmHandle,
> &selectionObject);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmSelectionObjectGet_04(void)
> +{
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = immutil_saImmOmSelectionObjectGet(immOmHandle,
> &selectionObject);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
