Hi Mohan,
Ack with minor comments.
Regards, Vu
> -----Original Message-----
> From: Mohan Kanakam <mo...@hasolutions.in>
> Sent: Friday, November 2, 2018 2:08 PM
> To: vu.m.ngu...@dektech.com.au; hans.nordeb...@ericsson.com
> Cc: opensaf-devel@lists.sourceforge.net; Mohan Kanakam
> <mo...@hasolutions.in>
> Subject: [PATCH 1/3] imm: add new test cases of API
> saImmOmClassCreate_2() of apitest [#2951]
>
> ---
> .../apitest/management/test_saImmOmClassCreate_2.c | 85
> ++++++++++++++++++++++
> 1 file changed, 85 insertions(+)
>
> diff --git a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> index 4f25f8b..9afbbe7 100644
> --- a/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> +++ b/src/imm/apitest/management/test_saImmOmClassCreate_2.c
> @@ -426,6 +426,80 @@ void saImmOmClassCreate_2_19(void)
> safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> }
>
> +void saImmOmClassCreate_2_20(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {"rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_CONFIG |
> SA_IMM_ATTR_RDN,
> + NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + rc = immutil_saImmOmClassCreate_2(-1, className,
> SA_IMM_CLASS_CONFIG,
> + attrDefinitions);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> + safassert(immutil_saImmOmFinalize(immOmHandle), SA_AIS_OK);
> +}
> +
> +void saImmOmClassCreate_2_21(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {"rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_CONFIG |
> SA_IMM_ATTR_RDN,
> + NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + rc = immutil_saImmOmClassCreate_2(immOmHandle, className,
> SA_IMM_CLASS_CONFIG,
> + attrDefinitions);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmClassCreate_2_22(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {
> + "rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_RUNTIME | SA_IMM_ATTR_RDN |
> SA_IMM_ATTR_CACHED, NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + rc = immutil_saImmOmClassCreate_2(immOmHandle, className,
> SA_IMM_CLASS_RUNTIME,
> + attrDefinitions);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmClassCreate_2_23(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {"rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_CONFIG |
> SA_IMM_ATTR_RDN,
> + NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = immutil_saImmOmClassCreate_2(immOmHandle, className,
> SA_IMM_CLASS_CONFIG,
> + attrDefinitions);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> +void saImmOmClassCreate_2_24(void)
> +{
> + const SaImmClassNameT className = (SaImmClassNameT)
> __FUNCTION__;
> + SaImmAttrDefinitionT_2 attr1 = {
> + "rdn", SA_IMM_ATTR_SANAMET,
> + SA_IMM_ATTR_RUNTIME | SA_IMM_ATTR_RDN |
> SA_IMM_ATTR_CACHED, NULL};
> + const SaImmAttrDefinitionT_2 *attrDefinitions[] = {&attr1, NULL};
> +
> + safassert(immutil_saImmOmInitialize(&immOmHandle,
> &immOmCallbacks, &immVersion),
> + SA_AIS_OK);
> + immutil_saImmOmFinalize(immOmHandle);
> + rc = immutil_saImmOmClassCreate_2(immOmHandle, className,
> SA_IMM_CLASS_RUNTIME,
> + attrDefinitions);
> + test_validate(rc, SA_AIS_ERR_BAD_HANDLE);
> +}
> +
> /*
> Verify it is not allowed to create IMM object class with reserved name.
> NOTE: As the list of reserved class names is read from the environment
> @@ -1497,6 +1571,17 @@ __attribute__((constructor)) static void
> saImmOmInitialize_constructor(void)
> test_case_add(
> 2, saImmOmClassCreate_2_19,
> "saImmOmClassCreate_2 - SA_AIS_OK, Create a class that has
> STRONG_DEFAULT flag without having default value");
> + test_case_add(2, saImmOmClassCreate_2_20,
> + "saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE
> CONFIG CLASS");
[Vu] Use lowercase for test slogans to align with existing ones and the
slogan for this test case seems not relevant. A suggestion "create config
class with invalid handle".
> + test_case_add(2, saImmOmClassCreate_2_21,
> + "saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE
> CONFIG CLASS UNINITLIZED HANDLE");
[Vu] Use lowercase for slogan. Please also revise followings.
> + test_case_add(2, saImmOmClassCreate_2_22,
> + "saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE
> RUNTIME CLASS UNINTILIZED HANDLE");
> + test_case_add(2, saImmOmClassCreate_2_23,
> + "saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE
> CONFIG CLASS FINALIZED HANDLE");
> + test_case_add(2, saImmOmClassCreate_2_24,
> + "saImmOmClassCreate_2 - SA_AIS_ERR_BAD_HANDLE
> RUNTIME CLASS FINALLIZED HANDLE");
> +
> test_case_add(
> 2, saImmOmClassCreate_with_reserved_name_01,
> "saImmOmClassCreate_2 - SA_AIS_ERR_INVALID_PARAM,"
> --
> 2.7.4
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
