Hi Carsten, > Hi Andreas, > > Andreas Zieringer wrote: >>> before you start screaming at me, because of the subject line, please >>> let me explain the issues: >>> 1) AFAICS the current implementation writes the AttachmentMap without >>> binding information and hence is not able to handle multiple attachments >>> with the same group id on a single container. >> yes right this was fixed in 1.8. > > ok, did you introduce a new version id for this change or did you > somehow manage to keep the file format unchanged ?
The format changed a bit but I maintained the upward compability but it breaks the backwards compability. Well for the backwards compability the version id wouldn't help so I didn't change it. As this feature is really rarely used it is not a big problem. >>> 2) Ptr mfields write size information twice, once as the binary size of >>> the field and then as the number of elements in the field. >>> >>> These changes will make the OSB format identical to what is transmitted >>> in the cluster, because for writing the copyToBin methods can be used, >>> instead of custom code (for reading custom code can not be avoided). >>> This will simplify the generic parts of OSB i/o. >> one point I write for each fieldcontainer and field the binary size out >> that's necessary if you want to skip unknown fieldcontainer or fields types. > > right, I was being vague. I wanted to keep the binary size but avoid > writing the number of elements as well, which is simply binary size/4. > I'm not doing this for the micro size optimization, but because I'd like > to use copyToBin ;) sounds ok. >>> Loading of 1.x OSB files will still be supported, but since there was no >>> release of 2 I don't think we need to support the current format. >> no problem for me. > > I'll ask on the users list as well, to see if someone objects. > > Thanks, > Carsten > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Opensg-core mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensg-core > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
