Hi Carsten, > Hi Andreas, > > Andreas Zieringer wrote: > >>>>>1) AFAICS the current implementation writes the AttachmentMap without >>>>>binding information and hence is not able to handle multiple attachments >>>>>with the same group id on a single container. >>>> >>>>yes right this was fixed in 1.8. >>> >>>ok, did you introduce a new version id for this change or did you >>>somehow manage to keep the file format unchanged ? >> >>The format changed a bit but I maintained the upward compability but it >>breaks the backwards compability. Well for the backwards compability the >>version id wouldn't help so I didn't change it. As this feature is >>really rarely used it is not a big problem. > > > The advantage of using a new version id is that you don't have to rely > on size comparisons to figure out what to read next. Right now this is > not a big deal, but add three more format changes into the mix and it > becomes quite a mess IMHO. Using the version ids makes it obvious which > code path reads which format. So I'd like to ask you to reconsider using > a new version id, or please explain the disadvantages of doing it, I > easily might be overlooking something.
This was the only format change I know of and there won't be more in 1.x. There is no extra version number for the AttachmentMap. I could change the osb version number this would make the current reading code be a bit nicer. Increasing the version number now is actually to late for already written osb files with multiple attachments this would lead to another extra code path. Perhaps I was a bit unclear only writing a osb files with multiple attachments will break the backwards compability writing a osb file with only one attachment keeps the backward compability. And for 2.0 we already incresed the version number. Andreas > Thanks, > Carsten > > > ------------------------------------------------------------------------- > Take Surveys. Earn Cash. Influence the Future of IT > Join SourceForge.net's Techsay panel and you'll get the chance to share your > opinions on IT & business topics through brief surveys - and earn cash > http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV > _______________________________________________ > Opensg-core mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensg-core > ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
