As Patrick said, we have been using this for quite a while. I think it is good to go, but I would really like to get some feedback from some of the core developers about the implementation. Does anyone have time to review this?
-Allen On Tue, Feb 24, 2009 at 6:03 PM, Patrick Hartling <[email protected]> wrote: > In an effort to help clarify these additions, I have attached two files that > show how the code looks when merged to the trunk: > > double_transform.patch: Modifications to existing files > double_transform_files.tar.bz2: New files to be added > > I am still working on testing OSG::DoubleTransform on the trunk, but so far, > things are looking good. > > -Patrick > > Aron Bierbaum wrote: >> >> On Fri, Feb 20, 2009 at 4:57 PM, Patrick Hartling >> <[email protected]> wrote: >>> >>> I have taken care of merging all the changes on the fcptr_stable_jun07 >>> branch except for two. I suspect that these should be reviewed before >>> merging to ensure that everyone can come to a consensus about how these >>> additions should be implemented. >>> >>> The first change is r1280: http://opensg.vrsource.org/trac/changeset/1280 >>> >>> Add a DoubleTransform core that allows for double precision >>> transformations. Allow to select a double precision matrix stack in >>> the render traversal at compile time. >>> >>> Does anyone have feedback on the implementation or questions about the >>> use of this new node core? We have been using it very successfully since >>> it was added back in June 2008. AFAIK, we have not been using the >>> single-precision transform core since then. >> >> I would like to point out that this code is only used when enabled at >> compile time, and also it allows you to mix and match double and >> single precision matrices. We actually only use double precision >> matrices for a large navigation matrix, and any transforms that >> position geometry on a global scale. This follows the concept of a >> floating origin, where the idea is that we want to OpenSG matrix stack >> to be stored in double precision so that by the time that we push a >> matrix onto the OpenGL stack it is close to 0.0, where floating point >> has more precision. >> >> -Aron >> >> >>> The second change is r1655: >>> http://opensg.vrsource.org/trac/changeset/1655 >>> >>> Add intersection code for double transforms. >>> >>> This one clearly depends on r1280 and fills in a missing piece of that >>> revision. >>> >>> Earlier today, I merged the performance monitor foreground that Allen >>> has been working on since the fcptr_stable_jun07 branch was created. I >>> did it all as one revision >>> (http://opensg.vrsource.org/trac/changeset/1763) and asked Allen to >>> verify that everything made it to the trunk intact. Allen has already >>> indicated that there are pieces of this that could be cleaned up, and he >>> may want to elaborate on that here. Otherwise, going through a code >>> review of this addition could be beneficial in general. >>> >>> -Patrick >>> >>> >>> -- >>> Patrick L. Hartling >>> Senior Software Engineer, Priority 5 >>> http://www.priority5.com/ >>> >>> The information transmitted in this communication is intended only for >>> the person or entity to which it is addressed and contains proprietary >>> material. Any review, retransmission, dissemination or other use of, or >>> taking of any action in reliance upon, this information by persons or >>> entities other than the intended recipient is prohibited. If you >>> received this in error, please destroy any copies, contact the sender >>> and delete the material from any computer. >>> >>> >>> >>> ------------------------------------------------------------------------------ >>> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, >>> CA >>> -OSBC tackles the biggest issue in open source: Open Sourcing the >>> Enterprise >>> -Strategies to boost innovation and cut costs with open source >>> participation >>> -Receive a $600 discount off the registration fee with the source code: >>> SFAD >>> http://p.sf.net/sfu/XcvMzF8H >>> _______________________________________________ >>> Opensg-core mailing list >>> [email protected] >>> https://lists.sourceforge.net/lists/listinfo/opensg-core >>> >>> > > > -- > Patrick L. Hartling > Senior Software Engineer, Priority 5 > http://www.priority5.com/ > > The information transmitted in this communication is intended only for > the person or entity to which it is addressed and contains proprietary > material. Any review, retransmission, dissemination or other use of, or > taking of any action in reliance upon, this information by persons or > entities other than the intended recipient is prohibited. If you > received this in error, please destroy any copies, contact the sender > and delete the material from any computer. > > ------------------------------------------------------------------------------ > Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA > -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise > -Strategies to boost innovation and cut costs with open source participation > -Receive a $600 discount off the registration fee with the source code: SFAD > http://p.sf.net/sfu/XcvMzF8H > _______________________________________________ > Opensg-core mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensg-core > > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
