Hi Gerrit, hi All,
Gerrit Voss wrote:
>
> looks ok to me, the only very minor comment would be to switch to
>
> #ifndef OSG_ENABLE_DOUBLE_MATRIX_STACK
> typedef std::pair<UInt32, Matrix> MatrixStore;
> #else
> typedef std::pair<UInt32, Matrix4d> DoubleMatrixStore;
> #endif
>
> in RenderPartition instead of having two MatrixStore / MatrixStack defs.
If you have two different names, why have an ifndef?
In general I like having the double transform, and I think it's great that you
wrote it (and we will probably need it in our Army project ;). So I'd love to
see it in trunk.
I'm just not too excited about having it as a compile-time decision, as that
either doubles the number of libraries we need to ship or we have to pick one
of
the two options. I know it's a lot more complicated to make it a runtime
choice,
so I understand why you did it, I'm just a little uneasy about it.
For now I think it makes sense it include it so that it's available, and I don'
think there's going to be a problem with the code as is, so please go ahead and
commit it to trunk.
Thanks!
Dirk
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core
