Hi,

On Wed, 2009-02-25 at 10:01 -0600, Dirk Reiners wrote:
>       Hi Gerrit, hi All,
> 
> Gerrit Voss wrote:
> 
> > 
> > looks ok to me, the only very minor comment would be to switch to
> > 
> > #ifndef OSG_ENABLE_DOUBLE_MATRIX_STACK
> >      typedef std::pair<UInt32, Matrix>              MatrixStore;
> > #else
> >     typedef std::pair<UInt32, Matrix4d>             DoubleMatrixStore;
> > #endif
> >  
> > in RenderPartition instead of having two MatrixStore / MatrixStack defs.
> 
> If you have two different names, why have an ifndef?

because I did the usual cut&paste screw up ;-), Of course both should be
MatrixStore.

kind regards,
  gerrit




------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core

Reply via email to