Hi,
On Tue, 2010-04-20 at 14:37 -0500, Carsten Neumann wrote:
> Hello all,
>
> attached patch series changes the way we create RenderTreeNodes from
> doing it inside RenderPartition::dropFunctor to TreeBuilderBase::add (or
> derived).
> This seems a cleaner interface as the RPart now does not have to care
> what the different TreeBuilder actually store in the RTNode. It also
> allows moving occlusion culling specific data into OCRenderTreeNode that
> is only used by the OcclusionCullingTreeBuilder, reducing the size of
> the base RTNode.
>
> Comments? [1]
>
at least a minor one, could you undo these changes, at least to existing
code:
-StateSortTreeBuilder::StateSortTreeBuilder(void) :
- _oSorter(),
- _mFallbackSorter()
+StateSortTreeBuilder::StateSortTreeBuilder(void)
+ : _pRoot (NULL)
+ , _oSorter ()
+ , _mFallbackSorter()
{
}
99% of the code uses the first form so either change all or none, but
please keep it consistent.
thanks
gerrit
------------------------------------------------------------------------------
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core
