Hi,
On Tue, 2010-04-20 at 16:02 -0500, Carsten Neumann wrote:
> Hello Gerrit,
>
> Gerrit Voß wrote:
> > at least a minor one, could you undo these changes, at least to existing
> > code:
> >
> > -StateSortTreeBuilder::StateSortTreeBuilder(void) :
> > - _oSorter(),
> > - _mFallbackSorter()
> > +StateSortTreeBuilder::StateSortTreeBuilder(void)
> > + : _pRoot (NULL)
> > + , _oSorter ()
> > + , _mFallbackSorter()
> > {
> > }
> >
> > 99% of the code uses the first form so either change all or none, but
> > please keep it consistent.
>
> ok, fixed, sorry about that; there was also a file missing, so I've
> attached the updated patch series. Thanks.
>
0003-fixed-remove-some-dead-code.patch
you are aware that the two code paths are no identical ? The
_mfChunks.clear path might trigger memory operations and other nonsense
in particular stl implementations (ms).
If we jumped the hoops to keep the memory alive by not using clear
initially I expect there might have been a reason. I'll check.
kind regards
gerrit
------------------------------------------------------------------------------
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core
