Hello Johannes,
On 2017-05-04 01:56, Johannes wrote:
> is this still in the pipeline?
yes, thank you for the reminder though. Since this modifies existing
code (as opposed to mostly adding new classes) I wanted to take a little
closer look.
- For OSGComputeShaderAlgorithm is it possible to combine the
useMemoryBarrier and memoryBarrier fields, i.e. if memoryBarrier is
GL_NONE that means no memory barrier? That would allow controlling the
barrier with a single field instead of requiring the setting of two.
- Can you imagine a situation where a barrier is needed/useful before
the compute shader? If so, should we have
preMemoryBarrier/postMemoryBarrier fields instead?
- In OSGGeo{Integral/Vector}BufferRefProperty you add getOpenGLId helper
functions, but then they appear to not be used. Did I miss something?
Other than these small things this is great and if the above triggers
changes they can be done as follow-ups; I'll commit the current state
now. Thank you for the additions!
Cheers,
Carsten
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
