Hi, sorry for being mostly silent, I'm chasing one deadline after another since beginning of the year.
On Wed, 2017-05-10 at 11:11 -0500, Carsten Neumann wrote: > Hello Johannes, > > On 2017-05-04 01:56, Johannes wrote: > > is this still in the pipeline? > > yes, thank you for the reminder though. Since this modifies existing > code (as opposed to mostly adding new classes) I wanted to take a little > closer look. > - For OSGComputeShaderAlgorithm is it possible to combine the > useMemoryBarrier and memoryBarrier fields, i.e. if memoryBarrier is > GL_NONE that means no memory barrier? That would allow controlling the > barrier with a single field instead of requiring the setting of two. > - Can you imagine a situation where a barrier is needed/useful before > the compute shader? If so, should we have > preMemoryBarrier/postMemoryBarrier fields instead? > - In OSGGeo{Integral/Vector}BufferRefProperty you add getOpenGLId helper > functions, but then they appear to not be used. Did I miss something? small comment, the *Ref* classes are meant to refer to/reference OpenSG external OpenGL objects, so validating them through OpenSG and translating them to an OpenSG managed OpenGL Id is not the intended behavior. So the changes to OSGGeo{Integral/Vector}BufferRefProperty will break existing code and kind of duplicate what the normal properties do. What was the reason behind these changes ? kind regards gerrit ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users