----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/340/#review760 -----------------------------------------------------------
Tested: I can produce a package with: autobuild install autobuild build autobuild package Haven't tested the resulting package, but it's content looks reasonable. autobuild.xml <http://codereview.secondlife.com/r/340/#comment717> I guess it's not a problem that the paths in the package will collide with the paths of the non-linux libndofdev package, or is it? (If they were built from the same source, they'd collide too, wouldn't they?) libndofdev/CMakeLists.txt <http://codereview.secondlife.com/r/340/#comment720> Jan Ciger's libndofdev comes with a Makefile. Why not use that? This lib is linux-specific, so we don't need a cross-platform build configuration for it. libndofdev/CMakeLists.txt <http://codereview.secondlife.com/r/340/#comment718> If these flags are added unconditionally, how would one do a 64-bit build? Maybe check for WORD_SIZE, like the viewer build does. libndofdev/CMakeLists.txt <http://codereview.secondlife.com/r/340/#comment719> Might be worth mentioning the non-linux libndofdev (and where to find it) in the error message. - Boroondas On June 16, 2011, 1:32 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/340/ > ----------------------------------------------------------- > > (Updated June 16, 2011, 1:32 p.m.) > > > Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo. > > > Summary > ------- > > Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for > linux. > * Added cmake build configuration. > * Added autobuild package configuration. > * Created libndofdev.txt license file from ndofdev.c file header. > * Added README to explain that this is only for use in the linux viewer. > > BUGFIXES: > * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= > 2.6.33. > > When reviewing, please provide extra scrutiny to autobuild.xml and > CMakeLists.txt, since those are the files I actually edited. > > > This addresses bugs OPEN-21, STORM-1320 and STORM-312. > http://jira.secondlife.com/browse/OPEN-21 > http://jira.secondlife.com/browse/STORM-1320 > http://jira.secondlife.com/browse/STORM-312 > > > Diffs > ----- > > autobuild.xml PRE-CREATION > libndofdev/CHANGELOG PRE-CREATION > libndofdev/CMakeLists.txt PRE-CREATION > libndofdev/LICENSES/libndofdev.txt PRE-CREATION > libndofdev/README PRE-CREATION > libndofdev/include/ndofdev_external.h PRE-CREATION > libndofdev/ndofdev.c PRE-CREATION > > Diff: http://codereview.secondlife.com/r/340/diff > > > Testing > ------- > > This built successfully on TeamCity and the packaged library worked correctly > when I extracted it into the packages directory of the viewer build tree ( > build-linux-i686/packages ). My spacenavigator, which hasn't worked in six > months, started working with the new build. > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
