> On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, lines 27-30 > > <http://codereview.secondlife.com/r/340/diff/1/?file=2972#file2972line27> > > > > Might be worth mentioning the non-linux libndofdev (and where to find > > it) in the error message. > > Jonathan Yap wrote: > On windows I already get 4 lines such as: > package pcre has no installation information configured for platform > windows > which is plenty of information for a package I have no need of; let's not > put too much unnecessary text on the screen.
Those messages are only be displayed during build configuration, and only if you try to build the package on windows or mac. They are there to alleviate confusion because we have two libndofdev packages, depending on the platform. Telling where to find the other library seems like a good idea. > On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > autobuild.xml, line 40 > > <http://codereview.secondlife.com/r/340/diff/1/?file=2970#file2970line40> > > > > I guess it's not a problem that the paths in the package will collide > > with the paths of the non-linux libndofdev package, or is it? > > > > (If they were built from the same source, they'd collide too, wouldn't > > they?) The .a file in /lib has to collide anyway to work right. Autobuild install shouldn't install more than one of the packages. > On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, line 1 > > <http://codereview.secondlife.com/r/340/diff/1/?file=2972#file2972line1> > > > > Jan Ciger's libndofdev comes with a Makefile. Why not use that? > > > > This lib is linux-specific, so we don't need a cross-platform build > > configuration for it. I would have needed to modify Jan's makefile to fit the autobuild package layout. I also used cmake because the other libndofdev library build also uses it. > On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, line 16 > > <http://codereview.secondlife.com/r/340/diff/1/?file=2972#file2972line16> > > > > If these flags are added unconditionally, how would one do a 64-bit > > build? Maybe check for WORD_SIZE, like the viewer build does. I see m32 hard coded in several other libraries, including 3p-google-mock - Log ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/340/#review760 ----------------------------------------------------------- On June 16, 2011, 1:32 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/340/ > ----------------------------------------------------------- > > (Updated June 16, 2011, 1:32 p.m.) > > > Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo. > > > Summary > ------- > > Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for > linux. > * Added cmake build configuration. > * Added autobuild package configuration. > * Created libndofdev.txt license file from ndofdev.c file header. > * Added README to explain that this is only for use in the linux viewer. > > BUGFIXES: > * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= > 2.6.33. > > When reviewing, please provide extra scrutiny to autobuild.xml and > CMakeLists.txt, since those are the files I actually edited. > > > This addresses bugs OPEN-21, STORM-1320 and STORM-312. > http://jira.secondlife.com/browse/OPEN-21 > http://jira.secondlife.com/browse/STORM-1320 > http://jira.secondlife.com/browse/STORM-312 > > > Diffs > ----- > > autobuild.xml PRE-CREATION > libndofdev/CHANGELOG PRE-CREATION > libndofdev/CMakeLists.txt PRE-CREATION > libndofdev/LICENSES/libndofdev.txt PRE-CREATION > libndofdev/README PRE-CREATION > libndofdev/include/ndofdev_external.h PRE-CREATION > libndofdev/ndofdev.c PRE-CREATION > > Diff: http://codereview.secondlife.com/r/340/diff > > > Testing > ------- > > This built successfully on TeamCity and the packaged library worked correctly > when I extracted it into the packages directory of the viewer build tree ( > build-linux-i686/packages ). My spacenavigator, which hasn't worked in six > months, started working with the new build. > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
