> On June 16, 2011, 4:59 p.m., Boroondas Gupte wrote: > > libndofdev/CMakeLists.txt, lines 27-30 > > <http://codereview.secondlife.com/r/340/diff/1/?file=2972#file2972line27> > > > > Might be worth mentioning the non-linux libndofdev (and where to find > > it) in the error message.
On windows I already get 4 lines such as: package pcre has no installation information configured for platform windows which is plenty of information for a package I have no need of; let's not put too much unnecessary text on the screen. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/340/#review760 ----------------------------------------------------------- On June 16, 2011, 1:32 p.m., Log Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/340/ > ----------------------------------------------------------- > > (Updated June 16, 2011, 1:32 p.m.) > > > Review request for Viewer, Oz Linden, Boroondas Gupte, and Altair Memo. > > > Summary > ------- > > Checked in version 0.3 of Jan Ciger's libndofdev drop-in replacement for > linux. > * Added cmake build configuration. > * Added autobuild package configuration. > * Created libndofdev.txt license file from ndofdev.c file header. > * Added README to explain that this is only for use in the linux viewer. > > BUGFIXES: > * OPEN-21 STORM-312 This version of libndofdev supports kernel versions >= > 2.6.33. > > When reviewing, please provide extra scrutiny to autobuild.xml and > CMakeLists.txt, since those are the files I actually edited. > > > This addresses bugs OPEN-21, STORM-1320 and STORM-312. > http://jira.secondlife.com/browse/OPEN-21 > http://jira.secondlife.com/browse/STORM-1320 > http://jira.secondlife.com/browse/STORM-312 > > > Diffs > ----- > > autobuild.xml PRE-CREATION > libndofdev/CHANGELOG PRE-CREATION > libndofdev/CMakeLists.txt PRE-CREATION > libndofdev/LICENSES/libndofdev.txt PRE-CREATION > libndofdev/README PRE-CREATION > libndofdev/include/ndofdev_external.h PRE-CREATION > libndofdev/ndofdev.c PRE-CREATION > > Diff: http://codereview.secondlife.com/r/340/diff > > > Testing > ------- > > This built successfully on TeamCity and the packaged library worked correctly > when I extracted it into the packages directory of the viewer build tree ( > build-linux-i686/packages ). My spacenavigator, which hasn't worked in six > months, started working with the new build. > > > Thanks, > > Log > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
