On Tue, Jan 09, 2001 at 10:44:19AM +0100, Richard Levitte - VMS Whacker wrote:
>> If MSDOS and VMS are in general not meant to be defined on
>> those systems, the exported headers should not define them
>> either.
> If we use MSDOS or VMS (and others, perhaps MS_STATIC?) in the rest of
> the exported headers (VMS is definitely used!), then the exported
> headers should define them if not already defined. This is a matter
> of consequence if nothing else.
The question is, do we really want to use MSDOS elsewhere if it is
not automatically defined on such systems. In library-internal
header files, we can do anything we want, but in exported header
files we should define as few "general" stuff as possible.
>> BTW, even e_os.h tests for MSDOS before it defines it. So
>> either it is defined anyway and e_os.h does not have to
>> define it, or e_os.h in itself is ridiculous.
> e_os.h makes sure not to destroy a value that MSDOS may already have.
> That's cautious, and therefore good.
Sure, but that's not the line I'm talking about. "defined(MSDOS)"
appears in line 105, and MSDOS is defined in lines 119-121.
>> Er, you are right. I moved it back into EXHEADER for simplicity
>> because the link in the source code include directory is needed.
>> To separate these things cleanly, there should be another type
>> of headers beside EXHEADER that is looked at by "make links",
>> but not by "make install". (We could put those files into
>> a new directory in the source directory tree.)
> For the top Makefile, I agree, but first of all, we need to expose a
> little more of the macro magic. Sorry, but that's the hard reality of
> it. Macros that are not exposed in any of the exported headers need
> to be exposed, anything else is stupid.
If we rename such macros to OPENSSL_whatever, we can define them
whenever we feel like it. If they have generic names, we should
be more careful. I guess MSDOS wouldn't really hurt to much,
but that's about the limit.
--
Bodo Möller <[EMAIL PROTECTED]>
PGP http://www.informatik.tu-darmstadt.de/TI/Mitarbeiter/moeller/0x36d2c658.html
* TU Darmstadt, Theoretische Informatik, Alexanderstr. 10, D-64283 Darmstadt
* Tel. +49-6151-16-6628, Fax +49-6151-16-6036
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [EMAIL PROTECTED]
Automated List Manager [EMAIL PROTECTED]
