Hello,

Latest snapshot broke mingw build for the following reasons:

1. ssl/kssl.c declares _XOPEN_SOURCE at source level and not at configuration 
level, this is invalid in some environments. Please consider moving this to 
Configure targets table. Also, I cannot see where strptime is used anyway... :)

2.util/domd was modified to exit on error, this is OK, but exposed a different 
error that was there since cross compile feature was added to build system. The 
domd uses gcc directly and ignores the cross compile prefix. Please make it use 
correct toolchain.

While we at it, one old minor issue with msys... For some strange reason perl 
reports that symlinks are available under msys, while it cannot create symbolic 
link when the to is not reachable from cwd. Attached is also a fix for this one.

Thanks,
Alon Bar-Lev.

---

diff -urNp openssl-SNAP-20081003.org/ssl/kssl.c openssl-SNAP-20081003/ssl/kssl.c
--- openssl-SNAP-20081003.org/ssl/kssl.c        2007-02-10 13:00:54.000000000 
+0200
+++ openssl-SNAP-20081003/ssl/kssl.c    2008-10-04 21:30:51.000000000 +0300
@@ -68,7 +68,6 @@
 
 #include <openssl/opensslconf.h>
 
-#define _XOPEN_SOURCE 500 /* glibc2 needs this to declare strptime() */
 #include <time.h>
 #if 0 /* Experimental */
 #undef _XOPEN_SOURCE /* To avoid clashes with anything else... */
diff -urNp openssl-SNAP-20081003.org/util/domd openssl-SNAP-20081003/util/domd
--- openssl-SNAP-20081003.org/util/domd 2008-09-09 23:00:21.000000000 +0300
+++ openssl-SNAP-20081003/util/domd     2008-10-04 21:29:05.000000000 +0300
@@ -22,7 +22,7 @@ if [ "$MAKEDEPEND" = "gcc" ]; then
     done
     sed -e '/^# DO NOT DELETE.*/,$d' < Makefile > Makefile.tmp
     echo '# DO NOT DELETE THIS LINE -- make depend depends on it.' >> 
Makefile.tmp
-    gcc -Werror -D OPENSSL_DOING_MAKEDEPEND -M $args >> Makefile.tmp || exit
+    gcc -D OPENSSL_DOING_MAKEDEPEND -M $args >> Makefile.tmp
     ${PERL} $TOP/util/clean-depend.pl < Makefile.tmp > Makefile.new
     rm -f Makefile.tmp
 else
diff -urNp openssl-SNAP-20080611.org/util/mklink.pl 
openssl-SNAP-20080611/util/mklink.pl
--- openssl-SNAP-20080611.org/util/mklink.pl    2006-02-09 15:00:35.000000000 
+0200
+++ openssl-SNAP-20080611/util/mklink.pl        2008-06-13 12:42:06.000000000 
+0300
@@ -51,6 +51,7 @@ my $to = join('/', @to_path);
 
 my $file;
 $symlink_exists=eval {symlink("",""); 1};
+if ($^O eq "msys") { $symlink_exists=0 };
 foreach $file (@files) {
     my $err = "";
     if ($symlink_exists) {

______________________________________________________________________
OpenSSL Project                                 http://www.openssl.org
Development Mailing List                       openssl-dev@openssl.org
Automated List Manager                           [EMAIL PROTECTED]

Reply via email to