On Tue, May 29, 2018 at 4:26 PM, Ian Wells <ijw.ubu...@cack.org.uk> wrote:
> On 29 May 2018 at 14:53, Jeremy Stanley <fu...@yuggoth.org> wrote: > >> On 2018-05-29 15:25:01 -0500 (-0500), Jay S Bryant wrote: >> [...] >> > Maybe it would be different now that I am a Core/PTL but in the past I >> had >> > been warned to be careful as it could be misinterpreted if I was >> changing >> > other people's patches or that it could look like I was trying to pad my >> > numbers. (I am a nit-picker though I do my best not to be. >> [...] >> >> Most stats tracking goes by the Gerrit "Owner" metadata or the Git >> "Author" field, neither of which are modified in a typical new >> patchset workflow and so carry over from the original patchset #1 >> (resetting Author requires creating a new commit from scratch or >> passing extra options to git to reset it, while changing the Owner >> needs a completely new Change-Id footer). >> > > We know this, but other people don't, so the comment is wise. Also, > arguably, if I badly fix someone else's patch, I'm making them look bad by > leaving them with the 'credit' for my bad work, so it's important to be > careful and tactful. But the history is public record, at least. > > If the patch is bad enough where I have to step in to rewrite, I'm making the submitter look bad no matter what. That makes everyone worse off. Best, Samuel > -- > Ian. > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev > >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
