On 01/27/2014 11:03 AM, Macdonald-Wallace, Matthew wrote: >>> I've also noticed just now that we appear to be "re-inventing" some parts of >> the logging framework (openstack.common.log.WriteableLogger for example >> appears to be a "catchall" when we should just be handing off to the default >> logger and letting the python logging framework decide what to do IMHO). >> >> WriteableLogger exists for a very specific reason: eventlet. Eventlet >> assumes a >> file object for logging, not a python logger. >> >> I've proposed a change for that - >> https://github.com/eventlet/eventlet/pull/75 - but it's not yet upstream. > > Thanks for clearing that up, makes a lot more sense now! > > So when the change is merged upstream we can get rid of that in our code as > well?
I'm pretty sure that's the only place it's used, so my hope is yes.
-Sean
--
Sean Dague
Samsung Research America
s...@dague.net / sean.da...@samsung.com
http://dague.net
signature.asc
Description: OpenPGP digital signature
_______________________________________________ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
