-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 17/05/14 02:48, W Chan wrote: > Regarding config opts for keystone, the keystoneclient middleware already > registers the opts at > https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/middleware/auth_token.py#L325 > > under a keystone_authtoken group in the config file. Currently, Mistral > registers the opts again at > https://github.com/stackforge/mistral/blob/master/mistral/config.py#L108 > under a > different configuration group. Should we remove the duplicate from Mistral > and > refactor the reference to keystone configurations to the keystone_authtoken > group? This seems more consistent.
I think that is the only thing that makes sense. Seems like a bug waiting to happen having the same options registered twice. If some user used to other projects comes and configures "keystone_authtoken" then will their config take effect? (how much confusion will that generate).. I'd suggest just using the one that is registered keystoneclient. - -Angus > > > On Thu, May 15, 2014 at 1:13 PM, W Chan <[email protected] > <mailto:[email protected]>> wrote: > > Currently, the various configurations are registered in > ./mistral/config.py. > The configurations are registered when mistral.config is referenced. > Given the way the code is written, PEP8 throws referenced but not used > error if mistral.config is referenced but not called in the module. In > various use cases, this is avoided by using importutils to import > mistral.config (i.e. > > https://github.com/stackforge/mistral/blob/master/mistral/tests/unit/engine/test_transport.py#L34). > I want to break down registration code in ./mistral/config.py into > separate functions for api, engine, db, etc and move the registration > closer > to the module where the configuration is needed. Any objections? > > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJThYdUAAoJEFrDYBLxZjWoxQgH/3K9Kqe9oKyMBl2lTbGbQTGp j3hJu5EKkG+2nUxW6m7yE5uZmNyauG2IrtU5xW5eOM+TvovyB23fRbyB7YCl57Y3 if1lXpn1pmv/+ELcPqHxpRyHTvj4eevU3zVb7tNhIHCrBq1jpGXoIzOg/9uWCrx8 SxgJzwD7lV+KAc4s3JAXTuRfmVXx4SJ0abSHXspqPhAD7Cio9McjK1xDex3j/SXc Z1JnYSrVTcs0/ynSc1z+CWB3N6F1fTX8Vltv7pjsKcTSPSuBLGNPRqftXgBSLeJ5 16clgrxOVJf1e8pfSva+feJ6Q49Rltw33nXjXha/cV5WIbb3umIDrK0xpRlJW0I= =O+uP -----END PGP SIGNATURE----- _______________________________________________ OpenStack-dev mailing list [email protected] http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
