On Mon, Mar 2, 2015 at 1:28 PM, Stefano Maffulli <stef...@openstack.org> wrote:
> On Mon, 2015-03-02 at 12:00 -0700, Doug Wiegley wrote: > > Why do you feel the need to keep them? Do your regularly look at > > older patches? Do you know anyone that does? > > > I don't think that's the point. The point is to try improving > contributor's life by providing them one last useful comment before > ignoring their contribution for good. > > To me, the abandon does this. It's basically giving a good reason for why it's being abandoned (4 weeks old, one -2. Or, 4 weeks old, no new comments), with a nice message on how to re-enable the patch and get fresh test results. > Tom gave a good suggestion IMHO and I've found a couple of cases where > maybe if someone reached out to the contributor and offered some help > probably their patch would have merged (or they would have learned a > useful, explicit lesson). Instead auto-abandon has *implicit* > connotation: a contributor may never know exactly why that patch was > abandoned. > > I suggest to give a second look at Tom's proposal because I think it > doesn't add any more workload on reviewers but provides for a clean exit > to a lagging changeset. > > /stef > > > > __________________________________________________________________________ > OpenStack Development Mailing List (not for usage questions) > Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev >
__________________________________________________________________________ OpenStack Development Mailing List (not for usage questions) Unsubscribe: openstack-dev-requ...@lists.openstack.org?subject:unsubscribe http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev