On 20/08/13 11:29, Gert Doering wrote: > Hi, > > On Tue, Aug 20, 2013 at 12:01:33PM +0300, Samuli Seppänen wrote: >>> We've had questions on #openvpn-devel about pull request 7, which was the >>> first time (on request *7*) that anyone was taking note that we offer >>> pull requests at all - so there's 7 pull requests out there that are >>> ignored. >> Well, we don't have the manpower to look at Trac bug reporting, and we >> still don't disable bug reporting, do we? :) > > This is a problem, indeed. But it's not an argument for adding yet another > queue that we don't look at.
In addition, we don't have "competing" alternatives to bug tracking on
the table. And we need bug tracking, unfortunately.
>> Anyways, I can keep an eye on the pull requests and if something
>> interesting pops up, I can forward those people to openvpn-devel. Or, if
>> we really want to disable pull requests, we should monitor the OpenVPN
>> forks in GitHub for something interesting, and encourage people to push
>> their stuff to main development line.
>
> I've never understood the hype around github, tbh. If you see value in
> adding to your workload, feel free to - but really, evidence speaks against
> enabling pull requests.
+1
> Also, Dazo and I won't actually *use* git-pull to fetch those, so one
> of the big reasons why you would want that ("to enable git pull") wouldn't
> apply anyway. We have agreed on a workflow how to integrate patches, and
> "pull" is not part of it. "git am" and "git push" are...
Even James sends patches to the mailing list for review nowadays, so we
don't even do git pull from his repos.
We've settled a long time ago that we wanted to review patches on the ML
to keep track of the process in a distributed manner (reviews are not
stored in a single server or with a single provider).
Github can have some kind of review as well, but is doing it in a
centralised manner. And it would require us to write new scripts to
automate git pulls as well - to get those extra review lines we add to
the commit logs. And if Github disappears, changes URL schema or
similar things, we've lost the references to the review. On the mailing
list, there is at least the Message-ID which is unique enough to even
use in google searches. Nothing is really lost if gmane.org or
sourceforge.net shuts down.
--
kind regards,
David Sommerseth
signature.asc
Description: OpenPGP digital signature
