Hi,
On Mon, Feb 1, 2016 at 11:34 AM, Selva Nair <[email protected]> wrote:
> Other comments I have are more specific to code snippets and of minor
> consequence. Will send them after compile/test runs
Following up on that, a couple of comments below:
HMODULE iphlpapi = GetModuleHandle (TEXT("iphlpapi.dll"));
> if (iphlpapi == NULL)
> return GetLastError ();
> CreateIpForwardEntry2 = (CreateIpForwardEntry2Fn) GetProcAddress
> (iphlpapi, "CreateIpForwardEntry2");
> if (!CreateIpForwardEntry2)
> return GetLastError ();
Is this run-time lookup necessary?
Anyway, the iservice works well and the only real problem I ran into was
lack of write access to the default log_dir. That leads to a log-jam as the
stdout is now a pipe which the service is not actively reading from. Could
be handled in the GUI + registry by making sure openvpn is started with a
writable log file..
Anyway, the service part of the code looks good and does well what it
promises to do.
Selva
