Hi,
On Wed, Feb 03, 2016 at 08:57:18PM -0500, Selva Nair wrote:
> On Mon, Feb 1, 2016 at 11:34 AM, Selva Nair <selva.n...@gmail.com> wrote:
>
> > Other comments I have are more specific to code snippets and of minor
> > consequence. Will send them after compile/test runs
>
> Following up on that, a couple of comments below:
>
> HMODULE iphlpapi = GetModuleHandle (TEXT("iphlpapi.dll"));
> > if (iphlpapi == NULL)
> > return GetLastError ();
> > CreateIpForwardEntry2 = (CreateIpForwardEntry2Fn) GetProcAddress
> > (iphlpapi, "CreateIpForwardEntry2");
> > if (!CreateIpForwardEntry2)
> > return GetLastError ();
>
> Is this run-time lookup necessary?
I don't think so - it might be a leftover of "we try to make this
compatible with windows XP", which we decided later to be a non-goal
for 2.4.
So we might replace this with just calling CreateIpForwardEntry2()
directly.
> Anyway, the iservice works well and the only real problem I ran into was
> lack of write access to the default log_dir. That leads to a log-jam as the
> stdout is now a pipe which the service is not actively reading from. Could
> be handled in the GUI + registry by making sure openvpn is started with a
> writable log file..
Yes, I've seen this as well. As far as I understand, there's a registry
key that can be changed to include the user's home in the log path - it's
on a piece of paper on my desk, while I'm at work, so can't look right
now... Heiko?
(And yes, this needs to be adjusted in the installer, whichever way we
go - globally writeable log directory, or user-individual logging)
> Anyway, the service part of the code looks good and does well what it
> promises to do.
Thanks. I take this as an ACK from your for the service change, and
Arne's mail as an ACK for the openvpn side, and merge it tonight.
Then we can go about improving things further (... while we wait for
the other large 2.4 feature to fully show up, AEAD...)
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
