Hi, On Thu, Feb 4, 2016 at 4:38 AM, Gert Doering <g...@greenie.muc.de> wrote:
> > Anyway, the iservice works well and the only real problem I ran into was > > lack of write access to the default log_dir. That leads to a log-jam as > the > > stdout is now a pipe which the service is not actively reading from. > Could > > be handled in the GUI + registry by making sure openvpn is started with a > > writable log file.. > > Yes, I've seen this as well. As far as I understand, there's a registry > key that can be changed to include the user's home in the log path - it's > on a piece of paper on my desk, while I'm at work, so can't look right > now... Heiko? > > (And yes, this needs to be adjusted in the installer, whichever way we > go - globally writeable log directory, or user-individual logging) Its the "HKLM\OpenVPN\log_dir" key set by the installer when the service is installed. For the automatic service, users may want it to stay at such a system-wide location, while the interactive service does not use it directly. But the UI (OpenVPNGUI) uses it to construct the log file path and passes it in the command line options. To make the log location user-dependent, we could include env variables in the registry key -- say %UserProfile%/OpenVPN/log But that requires the service to read the key as REG_EXPAND_SZ and then expand it. For now, I'll make a patch for the GUI to construct a writable log path when iservice is used. It looks ok to let the UI to decide where to write logs to. We could document that starting openvpn using iservice needs the --log or --log-append option with a writable log file. If its not writable openvpn will fallback to stdout which will not work. > Anyway, the service part of the code looks good and does well what it > > promises to do. > > Thanks. I take this as an ACK from your for the service change, and > Arne's mail as an ACK for the openvpn side, and merge it tonight. > > Then we can go about improving things further (... while we wait for > the other large 2.4 feature to fully show up, AEAD...) Sounds good! Selva
