Hi,
On Fri, Nov 11, 2016 at 02:16:41PM +0100, David Sommerseth wrote:
> @@ -917,6 +915,12 @@ do_ifconfig (struct tuntap *tt,
> management_android_control (management, "IFCONFIG", buf_bptr(&out));
>
> #elif defined(TARGET_SOLARIS)
> + const char *ifconfig_ipv6_remote = NULL;
> +
> + if (tt->did_ifconfig_ipv6_setup )
> + {
> + ifconfig_ipv6_remote = print_in6_addr (tt->remote_ipv6, 0, &gc);
> + }
NAK :-) - if you clean it up, do it right. Just stuff this into the
if clause where it is used, not introducing yet another if(), and make
the variable local to that block.
if ( do_ipv6 )
{
argv_printf (&argv, "%s %s inet6 unplumb",
IFCONFIG_PATH, actual );
argv_msg (M_INFO, &argv);
openvpn_execve_check (&argv, es, 0, NULL);
if ( tt->type == DEV_TYPE_TUN )
{
+ const char *ifconfig_ipv6_remote = print_in6_addr
(tt->remote_ipv6, 0, &gc);
argv_printf (&argv,
"%s %s inet6 plumb %s/%d %s up",
IFCONFIG_PATH,
actual,
ifconfig_ipv6_local,
tt->netbits_ipv6,
ifconfig_ipv6_remote
);
}
> @@ -1606,7 +1610,9 @@ open_tun_generic (const char *dev, const char
> *dev_type, const char *dev_node,
> tt->actual_name = string_alloc (dynamic_opened ? dynamic_name : dev,
> NULL);
> }
> }
> +#endif // !WIN32 && !TARGET_LINUX
And NAK again - we do not do // comments.
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]
fax: +49-89-35655025 [email protected]
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
