-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 16/11/16 17:26, Gert Doering wrote:
> Hi,
>
> On Tue, Nov 15, 2016 at 12:13:05AM +0100, David Sommerseth wrote:
>> Fixes two compiler warnings idetified by using CFLAGS=-O2
>
> Spelling...
Meh. Will fix that one.
>> 1) ifconfig_ipv6_remote is only used on Solaris, move the
>> declaration and assignment of this variable into the
>> TARGET_SOLARIS block.
>>
>> 2) Linux have it's own open_tun() function and does not depend on
>> open_tun_generic() at all. So do not exclude open_tun_generic()
>> if TARGET_LINUX is defined.
>
> Should that be an "So do not include... " or "So exclude..."?
yes :)
>> @@ -915,7 +913,6 @@ do_ifconfig (struct tuntap *tt,
>> management_android_control (management, "IFCONFIG",
>> buf_bptr(&out));
>>
>> #elif defined(TARGET_SOLARIS) -
>
> Whitespace change - intentional?
Yes, but we can skip it if it is a deal-breaker.
>> @@ -977,6 +974,9 @@ do_ifconfig (struct tuntap *tt,
>>
>> if ( tt->type == DEV_TYPE_TUN ) { + const char
>> *ifconfig_ipv6_remote = NULL; + + ifconfig_ipv6_remote =
>> print_in6_addr (tt->remote_ipv6, 0, &gc);
>
> Why have an extra initialization with NULL here, if all you want
> is "assing print_in6_addr"? Single line should be good (unless too
> long).
Yes, the line would exceed 80 characters, so this looked more readable.
- --
kind regards,
David Sommerseth
OpenVPN Technologies, Inc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
iQIcBAEBAgAGBQJYLIowAAoJEIbPlEyWcf3yqh4P/0XfeJtFkhyv0Zy9hpMvWqXd
UUvzy1eWi+YDpD0yj1gnsNXvGuuDSKdYJ8N7xihxJ+YbGQaHYq6h4CSzy9v8LXc1
tcdStM+73cGFOWeJujLsazJYmYJVxicbSkIU0wqTdjqI55Ac55Qzp5F5mns9gVoO
2bMVMmfrNUWTG/vRK77VU0/0lfuNAeXp0WdY0Xzz3ee+hWxFaVorVidVwmEqfiWk
87mVLC79jdPjYqlk8jMmaw2Cd32/sn5rje+9Lg49P8VghFOduxqx8oD7PQKzp9sA
HIcR0KPAPlHWgQpd+TX+ljHiEW/7jVrRuJNaubXSjFuDB/Ru9xxjJSL/DWPA4ahr
jaw8d/K1AdivYGhNGs3LqvFOsEJiZEK1Keo2JOPVSo7AoZDWUuYw1B8h3EcACPHr
RDG4Cay+tW6vQGyhcx+Q723f/ZNDG4pFfi4sYkiQ/xhQ4LZz3qR/J3hy13GjIVe0
lvg7vEZCJipPw7dgqDnyD4xrdlNwovkzSPv5GL/hQnyc+k9iYZyG825hYrftmDL6
BlJDyn2uXUXISHYSoibfRuBLOGEXjY14opWB1P5ZNHJL4NfdfPZOE2eZJvh7oF5J
NqA14XvRGl0qlYsJN/bBJAHsf+RSKD3pKEwcNjIkJlCJj1AvBD4Nd/TQ51ok1r1r
+R5LyZIRg0UtQrmWpZXi
=Xo64
-----END PGP SIGNATURE-----
------------------------------------------------------------------------------
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
