Hi, On Tue, Nov 15, 2016 at 12:13:05AM +0100, David Sommerseth wrote: > Fixes two compiler warnings idetified by using CFLAGS=-O2
Spelling...
> 1) ifconfig_ipv6_remote is only used on Solaris, move the
> declaration and assignment of this variable into the
> TARGET_SOLARIS block.
>
> 2) Linux have it's own open_tun() function and does not
> depend on open_tun_generic() at all. So do not exclude
> open_tun_generic() if TARGET_LINUX is defined.
Should that be an "So do not include... " or "So exclude..."?
> @@ -915,7 +913,6 @@ do_ifconfig (struct tuntap *tt,
> management_android_control (management, "IFCONFIG", buf_bptr(&out));
>
> #elif defined(TARGET_SOLARIS)
> -
Whitespace change - intentional?
> @@ -977,6 +974,9 @@ do_ifconfig (struct tuntap *tt,
>
> if ( tt->type == DEV_TYPE_TUN )
> {
> + const char *ifconfig_ipv6_remote = NULL;
> +
> + ifconfig_ipv6_remote = print_in6_addr (tt->remote_ipv6, 0, &gc);
Why have an extra initialization with NULL here, if all you want is
"assing print_in6_addr"? Single line should be good (unless too long).
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany [email protected]
fax: +49-89-35655025 [email protected]
signature.asc
Description: PGP signature
------------------------------------------------------------------------------
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
