On 12/12/16 12:47, Lev Stipakov wrote:
> Async push functionality makes sense only with deferred authentication,
> which requires plugins.
>
> Trac #783
>
> Signed-off-by: Lev Stipakov <lstipa...@gmail.com>
> ---
> configure.ac | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index 27bdcc3..946f3db 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1204,6 +1204,10 @@ if test "${enable_plugin_auth_pam}" = "yes"; then
> fi
>
> if test "${enable_async_push}" = "yes"; then
> + if test "${enable_plugins}" = "no"; then
> + AC_MSG_ERROR([--enable_async_push requires --enable-plugins])
> + fi
> +
> AC_CHECK_HEADERS(
> [sys/inotify.h],
> AC_DEFINE([ENABLE_ASYNC_PUSH], [1], [Enable async push]),
> Coupling --enable-async-push with --enable-plugins makes a lot of sense. By the way, there is a typo in the errror message though (--enable_async_push should be --enable-async-push). But I am wondering if it would be better to just do this in syshead.h instead: #if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) #undef ENABLE_ASYNC_PUSH #endif Or another more verbose patch would be to have all #ifdef ENABLE_ASYNC_PUSH updated to also check for defined(ENABLE_PLUGIN), but I think that's overdoing it a bit. My point is that there's no real point of screaming about missing --enable-plugins if you have added --enable-auth-push. If you build without plugins support, --plugin in configurations won't work regardless. I think it is more likely that those adding --disable-plugins (it is enabled by default) believe --enable-async-push does something completely different. Rather have in the help line of --enable-async-push that it depends on the plug-in feature. -- kind regards, David Sommerseth OpenVPN Technologies, Inc
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
