Hi, On Tue, Dec 13, 2016 at 01:15:03AM +0100, David Sommerseth wrote: > But I am wondering if it would be better to just do this in syshead.h > instead: > > #if !defined(ENABLE_PLUGIN) && defined(ENABLE_ASYNC_PUSH) > #undef ENABLE_ASYNC_PUSH > #endif
We discussed this on IRC yesterday, and I like Lev's approach more.
Your approach will "silently not do what the user requested" - the user
configured "--enable-async-push", and the resulting binary will not
have that functionality because we turned it off again.
So erroring out in configure if incompatible build options are requested
sounds like a logical way to tell the caller "this is not what you want".
[..]
> My point is that there's no real point of screaming about missing
> --enable-plugins if you have added --enable-auth-push.
Someone added --enable-async-push to the configure command line, and they
expect this to have a different effect than "not putting it there".
gert
--
USENET is *not* the non-clickable part of WWW!
//www.muc.de/~gert/
Gert Doering - Munich, Germany g...@greenie.muc.de
fax: +49-89-35655025 g...@net.informatik.tu-muenchen.de
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
