13.12.2016, 02:15, David Sommerseth kirjoitti: > Coupling --enable-async-push with --enable-plugins makes a lot of sense. > By the way, there is a typo in the errror message though > (--enable_async_push should be --enable-async-push).
Yes :( I wonder if actual committer could fix it or should I send V2. > regardless. I think it is more likely that those adding > --disable-plugins (it is enabled by default) believe --enable-async-push > does something completely different. Rather have in the help line of > --enable-async-push that it depends on the plug-in feature. I do not have a strong opinion about that, but IMO having both --enable-async-push (1) and --disable-plugins (2) is a configuration error, since feature (1) depends on feature (2) and warn about it during build phase is more clear rather than silently disable feature (1). I could send V2 with fixed error message and clarified async-push help line, or alternatively V2 with clarified help line and fix in syshead.h you've suggested :) -Lev ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
