On Sun, Mar 04 2018, Selva Nair <selva.n...@gmail.com> wrote: > Hi, > > On Sun, Mar 4, 2018 at 1:48 PM, Jeremie Courreges-Anglas <j...@wxcvbn.org> > wrote: >> On Sun, Mar 04 2018, selva.n...@gmail.com wrote: >>> From: Selva Nair <selva.n...@gmail.com> >>> >>> Openssl docs do not explicitly state these to be macros although they >>> are currently defined as such. >> >> Actually they are documented as macros by OpenSSL since day 1, see >> NOTES. > > You are right, I missed that in the docs. In that case my patch is not > needed especially so if libressl will provide those macros.
It all depends if you want to support LibreSSL 2.6.x installations, as I'm not sure I'll be able to backport this in the 2.6 branch (which is supposed to receive security/reliability fixes only). > I'm still concerned about set and get functions coming from different > sources Indeed. A diff is floating to also add the getters to LibreSSL, hopefully this will make it in the upcoming 2.7.x release. > and may be we should fix that by requiring that if set is > defined we need get too. But that will once again break libressl > compatibility. From a mail I sent recently: --8<-- [...]. OpenSSL itself only provided said setters (since 2015)[2]. The getters were added to OpenSSL later (Sep 2017)[3]. [2] https://github.com/openssl/openssl/commit/7946ab33cecce60afcc00afc8fc18f31f9e66bff [3] https://github.com/openssl/openssl/commit/3edabd3ccb7aac89af5a63cfb2378e33a8be05d7 -->8-- IIUC there are OpenSSL 1.1.0 releases out there that provide only the setters, and that would also be affected by the requirement you propose. Github suggests that besides the master branch, the following tags have the setters[2]: OpenSSL_1_1_1-pre2 OpenSSL_1_1_1-pre1 OpenSSL_1_1_0 OpenSSL_1_1_0g OpenSSL_1_1_0f OpenSSL_1_1_0e OpenSSL_1_1_0d OpenSSL_1_1_0c OpenSSL_1_1_0b OpenSSL_1_1_0a OpenSSL_1_1_0-pre6 OpenSSL_1_1_0-pre5 OpenSSL_1_1_0-pre4 OpenSSL_1_1_0-pre3 OpenSSL_1_1_0-pre2 while support for getters[3] is only in: OpenSSL_1_1_1-pre2 OpenSSL_1_1_1-pre1 -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
signature.asc
Description: PGP signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
