Hi, On 15-06-18 09:46, Antonio Quartulli wrote: > > > On 08/12/17 20:07, Steffan Karger wrote: >> To avoid having to include misc.c - which is a dependency mess - in the >> tls-crypt unit tests, move file-handing related functions to platform.c >> (which is where other file-related functions already reside). >> >> Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com> > > I have applied this patch right after the one about PEM and it triggered > the following: > > Falling back to patching base and 3-way merge... > > How about rebasing it before the actual tls-crypt-v2 patches so that it > could be applied earlier and shrink down this patchset? > > > On top of that, would you please extend the commit message a little bit > to include the fact that you are adding a new mock'd component > (get_random) needed by the tls-crypt unit-test? > > Actually....If I understand correctly, this new mock'd component will > only be used when the other patches will be merged too. > Therefore, I guess this patch could be divided in 2: one part being the > code move and the second part being the introduction of the mock'd > component. The latter may directly be included in the patch adding the > tls-crypt unit-test. > > What do you think?
I think you have a good point. I'll reorder, split and merge. > Other than this, the patch looks good. > Checked with "git show --color-moved=zebra" to ensure that the code > being moved wasn't modified. > > And +1 for this patch for cleaning up the misc.c mess some more. Thanks! -Steffan ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
