Hi, On 08/12/17 20:07, Steffan Karger wrote: > From: Steffan Karger <stef...@karger.me> > > To avoid having to include misc.c - which is a dependency mess - in the > tls-crypt unit tests, move the command execution helper functions to a new > run_command.c module. > > While at it, abstract away the script_security global variable. > > Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
I can't apply this patch without having applied the tls-crypt-v2 patches first, however I strongly believe that this patch should come before those. Like the those about PEM_encode/decode and and platform_file_*. This would ensure that the tls-crypt unit-test, once introduced, will have all the required pieces to work right away (bisect will benefit from this too). I also see that here you are removing the script_security variable that you had declared in your first patch (in the crypt unit-test). How about re-arranging this patch (maybe by making it the first patch in the set) so that you don't need to do and undo the same code? Does it make sense? Cheers, -- Antonio Quartulli
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
