Hi,

*this* mail should have never gone out, it was the first draft yesterday
after which I noticed that it failed cmocka testing...  so, please ignore
it.

git head is

commit 68b97b25e4c479156d697bf3df90a4b68fbbbcea (HEAD -> master, stable/master, 
gitlab/master, github/master, delta2/master)
Author: Steffan Karger <steffan.kar...@fox-it.com>
Date:   Fri Dec 8 13:07:47 2017 +0100

    Move env helper functions into their own module/file


On Thu, Mar 08, 2018 at 05:02:58PM +0100, Gert Doering wrote:
> Acked-by: Gert Doering <g...@greenie.muc.de>
> 
> Does what it says on the lid: code is moved 1:1 with no code changes, 
> and only #include lines are adjusted elsewhere (which is actually painful
> to review in this case, as the "moved out" stuff was scattered along
> misc.c and parts ended in env_set.h, so "plain diff" between old-misc.c 
> and new-env_set.c didn't help much).
> 
> One small catch: this collided with 06ad53e067d9a8b and setenv_long_long()
> being changed from "%lld" to PRIi64 - so I changed the patch accordingly
> so that it still only moves lines from misc.c to env_set.c
> 
> Your patch has been applied to the master branch.
> 
> commit 0afe0ca5620d5ab7cec3380d40048dce2286f048
> Author: Steffan Karger
> Date:   Fri Dec 8 13:07:47 2017 +0100
> 
>      Move env helper functions into their own module/file
> 
>      Signed-off-by: Antonio Quartulli <anto...@openvpn.net>
>      Signed-off-by: Steffan Karger <steffan.kar...@fox-it.com>
>      Acked-by: Gert Doering <g...@greenie.muc.de>
>      Message-Id: <1512734870-17133-8-git-send-email-steffan.kar...@fox-it.com>
>      URL: 
> https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg16066.html
>      Signed-off-by: Gert Doering <g...@greenie.muc.de>
> 
> 
> --
> kind regards,
> 
> Gert Doering
> 
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> _______________________________________________
> Openvpn-devel mailing list
> Openvpn-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openvpn-devel
> 

-- 
now what should I write here...

Gert Doering - Munich, Germany                             g...@greenie.muc.de

Attachment: signature.asc
Description: PGP signature

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to