Acked-by: Gert Doering <g...@greenie.muc.de>

Thanks.  I have not tested the various error conditions, but the code
makes sense to me and it passes compile and t_client tests (which use
--up here), so it's not breaking stuff in fundamental and non-obvious
ways.

(Since David was mostly happy with the v1 approach except for the
"127" and "switch()", I assume he's totally fine with v2 now :-) )

Your patch has been applied to the master branch - it won't apply to
2.4 as we have no "run_command.*" there yet.  Shall we cherrypick
bf97c00f7dba4 and 253f015558 to get there?  Or do you want to do a
2.4 version of the patch?

commit 01a3c876d4911ff7ea82b04edeb43defdebc69d7 (master)
Author: Selva Nair
Date:   Wed Feb 20 19:46:22 2019 -0500

     Better error message when script fails due to script-security setting

     Signed-off-by: Selva Nair <selva.n...@gmail.com>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <1550709982-19319-1-git-send-email-selva.n...@gmail.com>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg18223.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to