Hi, On Thu, Feb 28, 2019 at 12:25 PM Gert Doering <g...@greenie.muc.de> wrote:
> Acked-by: Gert Doering <g...@greenie.muc.de> > > Thanks. I have not tested the various error conditions, but the code > makes sense to me and it passes compile and t_client tests (which use > --up here), so it's not breaking stuff in fundamental and non-obvious > ways. > > (Since David was mostly happy with the v1 approach except for the > "127" and "switch()", I assume he's totally fine with v2 now :-) ) > > Your patch has been applied to the master branch - it won't apply to > 2.4 as we have no "run_command.*" there yet. Shall we cherrypick > bf97c00f7dba4 and 253f015558 to get there? Or do you want to do a > 2.4 version of the patch? > Would require more cherry-picks than that, or some manual edits, isn't it? I can send a patch for 2.4 -- would you prefer the same as this -- i.e with switch(stat) in misc.c and and preprocessor macros in misc.h or a simpler, return code = -2 and error message as in version 1? Selva
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
