Hi, going through OpenVPN threads that went stale - I think this is actually a nice addition (read: other people have already asked me if this can be done).
On Thu, Mar 05, 2020 at 01:53:12PM +0100, Jan Just Keijser wrote:
> So, for what it's worth, I've dusted off the patch again and rebased it
> to the current openvpn master tree. See attached. Note that I did only
> rudimentary testing, as I don't use Windows 10 a lot and I was testing
> using a mingw cross-compile only. In wireshark I *do* see that the
> correct DHCP offer is sent to the tap-win adapter.
>
> Also note that I implemented multiple search domains by separating them
> using semi-colons, e.g.
>
> --dhcp-option SEARCH example.com;example.org;example.nl;example.de
>
> etc as that was easier to implement
The patch looks okay-ish on quick reading.
> Also note that I did not fully implement the RFC3397 encoding of the
> search list, as that requires one to merge domain names that occur more
> than once - that would have made the code far more complicated.
Indeed. I haven't looked at what other DHCP implementations do, but
"correct" encoding definitly sounds like quite a bit of extra code just
to save a few bytes on the wire - might come handy if you have many
subdomains of a long internal DNS domain, though, but this can be
added "if needed".
More interesting is the question "which option to use" - it should
be synchronized between openvpn platform handlers. So if systemd-networkd
uses "SEARCH-DOMAIN" it would make sense to use that for windows
as well.
Is there an option in Tunnelblick to set MacOS DNS and search list? If
yes, what option do they use?
Does anyone know about commercial VPN providers basing their clients
on OpenVPN?
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
