Re: [Openvpn-devel] [PATCH v2 1/2] Move examples into openvpn-examples(5) man page

[David Sommerseth]

On 20/05/2021 17:09, Arne Schwabe wrote:

Signed-off-by: Arne Schwabe <a...@rfc2549.org>
---
  .gitignore                 |  2 ++
  doc/Makefile.am            | 25 +++++++++++++++++++++----
  doc/openvpn-examples.5.rst | 17 +++++++++++++++++
  doc/openvpn.8.rst          |  2 +-
  4 files changed, 41 insertions(+), 5 deletions(-)
  create mode 100644 doc/openvpn-examples.5.rst

diff --git a/.gitignore b/.gitignore
index 25d06235b..178076ede 100644
--- a/.gitignore
+++ b/.gitignore
@@ -49,6 +49,8 @@ version.sh
  msvc-env-local.bat
  config-msvc-local.h
  config-msvc-version.h
+doc/openvpn-examples.5
+doc/openvpn-examples.5.html
  doc/openvpn.8
  doc/openvpn.8.html
  /doc/doxygen/html/
diff --git a/doc/Makefile.am b/doc/Makefile.am
index e411f5f9d..1dbbddf58 100644
--- a/doc/Makefile.am
+++ b/doc/Makefile.am
@@ -20,6 +20,7 @@ dist_doc_DATA = \
  dist_noinst_DATA = \
        README.plugins interactive-service-notes.rst \
        openvpn.8.rst \
+    openvpn-examples.5.rst \

This can be fixed during commit.


[...snip...]

TAB vs spaces. Makefile.am uses TABs. This might not be a real issue anymore, but there are some older Make versions which will choke on spaces.

  if HAVE_PYDOCUTILS
-dist_noinst_DATA += openvpn.8
-dist_html_DATA = openvpn.8.html
+dist_noinst_DATA += openvpn.8 openvpn-examples.5
+dist_html_DATA = openvpn.8.html openvpn-examples.5.html

  CLEANFILES = \
-        openvpn.8 openvpn.8.html
+        openvpn.8 openvpn.8.html openvpn-examples.5 openvpn-examples.5.html

  dist_man_MANS = openvpn.8

# Failsafe - do not delete these files unless we can recreate them endif @@ -74,4 +91,4 @@ else

Except of these two really minor things, this is good to go.

Acked-By: David Sommerseth <dav...@openvpn.net>


--
kind regards,

David Sommerseth
OpenVPN Inc

You missed openvpn-examples.5 here. But I do have a patch ready which avoids lots of the rule duplications. Gert got a copy of a preliminary patch to test on some BSD hosts. So we can ignore this for now.

OpenPGP_signature
Description: OpenPGP digital signature

_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel