On Tue, Oct 11, 2022 at 01:49:35PM +0200, Arne Schwabe wrote: > From the implemention and the fact that it is a an OCC message > (basically the rudimentary predecessor to control channel), > this message is very old. > > I think in the past this feature fit nicely to the weird inetd + openvpn mode > that seems to have far to many hacks still left in our code. With inetd, > it made sense that the server instance quits if you press C-c on the client. > > In our current state where inetd is no longer supported, this behaviour > to exit makes little sense and this patch changes the behaviour to SIGUSR1. > > The P2MP mode nees to keep the SIGTERM behaviour to terminate that client > session, so we use different signals based on the mode. > > Patch v2: use different signals for p2mp and p2p
IMHO the amount of copied code and logic is big enough to warrant moving it to a shared function. Regards, -- Frank Lichtenheld _______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
