Acked-by: Gert Doering <g...@greenie.muc.de>

I'm not sure if my gremlins have ever seen this particular problem, but
it seems yours have been more active :-)

Stare-at-code confirms that "buf_init()" is the way we clear dco_packet_in
in the existing code paths, "if a packet has been consumed", and doing so
in these two places ("we do not want any packet, go away") sounds like the
right thing to do (otherwise dco_linux::ovpn_handle_msg() will get very
upset trying to read the next incoming message).

Tested on the Linux/DCO test rig, client+server.  FreeBSD never sends
data packets via the DCO interface, and Windows does not even have this
structure element.

Your patch has been applied to the master and release/2.6 branch.

commit 7433618cb4bea017ae7c360da42093f49cf014b4 (master)
commit 474fe4df7d04de0eaa4cfe48b06497008275451a (release/2.6)
Author: Arne Schwabe
Date:   Sat Dec 24 20:42:49 2022 +0100

     Also drop incoming dco packet content when dropping the packet

     Signed-off-by: Arne Schwabe <a...@rfc2549.org>
     Acked-by: Gert Doering <g...@greenie.muc.de>
     Message-Id: <20221224194253.3202231-6-a...@rfc2549.org>
     URL: 
https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg25797.html
     Signed-off-by: Gert Doering <g...@greenie.muc.de>


--
kind regards,

Gert Doering



_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to