Hi, On Sat, Dec 24, 2022 at 08:42:51PM +0100, Arne Schwabe wrote: > Instead of getting the server in a very weird state, we bail out here. This > is only a bandaid solution but better than the alternatives. > > Signed-off-by: Arne Schwabe <a...@rfc2549.org>
Having a clear failure indication in the log and towards the client
is good, so definitely Feature-ACK.
I did also observe this when running the gremlin TCP test last night,
with 4/9 applied
Dec 25 02:49:44 ubuntu2004 tun-tcp-p2mp-username-cn[1828024]: ovpn-dco
installed socket with residual read len=0, mi=gremlin84091/194.97.140.21:10133.
This connection will probably break.
Dec 25 02:49:46 ubuntu2004 tun-tcp-p2mp-username-cn[1828024]: ovpn-dco
installed socket with residual read len=0, mi=gremlin84091/194.97.140.21:10133.
This connection will probably break.
Dec 25 02:49:47 ubuntu2004 tun-tcp-p2mp-username-cn[1828024]: ovpn-dco
installed socket with residual read len=0, mi=gremlin84091/194.97.140.21:10133.
This connection will probably break.
Dec 25 02:49:48 ubuntu2004 tun-tcp-p2mp-username-cn[1828024]: ovpn-dco
installed socket with residual read len=0, mi=gremlin84091/194.97.140.21:10133.
This connection will probably break.
... with a single instance (gremlin84091) having 2905 lines of log - so
this is certainly not a state we want the server to be in (other instances
only show up once, or 4 or 22 times... whatever OpenVPN does here).
This does not apply as it needs 4/9, and *that* one breaks inbound TCP
for me, so postponing this patch until we understand why 4/ doesn't work.
gert
--
"If was one thing all people took for granted, was conviction that if you
feed honest figures into a computer, honest figures come out. Never doubted
it myself till I met a computer with a sense of humor."
Robert A. Heinlein, The Moon is a Harsh Mistress
Gert Doering - Munich, Germany g...@greenie.muc.de
signature.asc
Description: PGP signature
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
