Attention is currently required from: cron2, ordex, plaisthos, selvanair, stipa.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service ...................................................................... Patch Set 1: (4 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/321/comment/e7e6ec3b_6554de56 : PS1, Line 1089: * @param action "delete" or "add" This says "add" but the rest of the function seems to use "set". But also see below for "add" vs "set". http://gerrit.openvpn.net/c/openvpn/+/321/comment/9fdd7e73_de5a661e : PS1, Line 1094: * if action = "set" then "static" is added before $addr Why are you using "set" here? The documentation (https://learn.microsoft.com/en-us/previous-versions/windows/it-pro/windows-server-2008-r2-and-2008/cc731521(v=ws.10)#set-winsserver) seems to suggest that that can only set one WINS server ("If the interface is already statically configured, the static parameter replaces the existing WINS server address list with the one specified in the set winsserver command.") Shouldn't you use "add" instead? http://gerrit.openvpn.net/c/openvpn/+/321/comment/a93a828d_867cc63f : PS1, Line 1406: if (addr_len > 0 || msg->header.type == msg_del_wins_cfg) Is there ever a case where this would be false? http://gerrit.openvpn.net/c/openvpn/+/321/comment/f983786a_f046e4f1 : PS1, Line 1436: if (msg->addr_len > 0) Nitpick: Should be addr_len, not msg->addr_len -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/321?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607 Gerrit-Change-Number: 321 Gerrit-PatchSet: 1 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 09:29:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
