Attention is currently required from: cron2, flichtenheld, ordex, plaisthos, 
stipa.

selvanair has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/321?usp=email )

Change subject: Set WINS servers via interactice service
......................................................................


Patch Set 3:

(1 comment)

File src/openvpnserv/interactive.c:

http://gerrit.openvpn.net/c/openvpn/+/321/comment/d18799fd_594b4a55 :
PS1, Line 1406:     if (addr_len > 0 || msg->header.type == msg_del_wins_cfg)
> Acknowledged
Though the process is unprivileged, its started by the privileged service which 
ensures that the process is a trusted executable installed in a particular 
location etc. So messages received via the msg-channel pipe can be trusted. 
Note that this pipe is created by the service with a single instance 
restriction and the handle passed on to openvpn.exe. Without this guarantee 
iservice would have been far less safe and secure.

Only the client process (like the GUI) is untrusted.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/321?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: release/2.6
Gerrit-Change-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607
Gerrit-Change-Number: 321
Gerrit-PatchSet: 3
Gerrit-Owner: stipa <lstipa...@gmail.com>
Gerrit-Reviewer: cron2
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: ordex <a...@unstable.cc>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: selvanair <selva.n...@gmail.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: cron2
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: ordex <a...@unstable.cc>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Mon, 31 Jul 2023 16:37:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: stipa <lstipa...@gmail.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to