Attention is currently required from: cron2, flichtenheld, ordex, plaisthos, selvanair.
stipa has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/321?usp=email ) Change subject: Set WINS servers via interactice service ...................................................................... Patch Set 3: (3 comments) File src/openvpnserv/interactive.c: http://gerrit.openvpn.net/c/openvpn/+/321/comment/0b804f50_4d9c1022 : PS1, Line 1089: * @param action "delete" or "add" > Right. I copypasted it from DNS version which uses add. Done http://gerrit.openvpn.net/c/openvpn/+/321/comment/8542b98a_e7eb2982 : PS1, Line 1094: * if action = "set" then "static" is added before $addr > Good point. […] Done http://gerrit.openvpn.net/c/openvpn/+/321/comment/7183cc1d_59f0330f : PS1, Line 1436: if (msg->addr_len > 0) > Should not matter here, copypaste from similar DNS function. But I can change > it. Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/321?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: release/2.6 Gerrit-Change-Id: I47c22dcb728011dcedaae47cd03a57219e9c7607 Gerrit-Change-Number: 321 Gerrit-PatchSet: 3 Gerrit-Owner: stipa <lstipa...@gmail.com> Gerrit-Reviewer: cron2 Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: ordex <a...@unstable.cc> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: selvanair <selva.n...@gmail.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <a...@unstable.cc> Gerrit-Attention: selvanair <selva.n...@gmail.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 11:30:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
