Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )
Change subject: Remove ability to use configurations without TLS by default ...................................................................... Patch Set 2: Code-Review-1 (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/325/comment/379190bd_a9c3fa7a : PS2, Line 12: line or the configuration itself. This will server as a last and final "serve" Patchset: PS2: Some documentation fixes required. But overall looks okay. File doc/man-sections/protocol-options.rst: http://gerrit.openvpn.net/c/openvpn/+/325/comment/f506bc1e_c4d07ee5 : PS2, Line 237: --secret args I think we should at least add a basic documentation for the "allow-deprecated-insecure-static-crypto" to the man page. I think there should be some documentation where people can look up what it means when they encounter it. File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/325/comment/2666ce9a_7234c17d : PS2, Line 618: ,\ Change trailing comma to full stop. http://gerrit.openvpn.net/c/openvpn/+/325/comment/5089d435_2a81c525 : PS2, Line 756: secret Should be we change the "secret" here? http://gerrit.openvpn.net/c/openvpn/+/325/comment/310f2f25_827ef514 : PS2, Line 2843: "OpenVPN 2.7 allow using this configuration when using " "allows" http://gerrit.openvpn.net/c/openvpn/+/325/comment/3b4c5d7f_d4849c88 : PS2, Line 2845: configuration "proper configuration" => "TLS mode"? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5 Gerrit-Change-Number: 325 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Mon, 21 Aug 2023 09:26:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
