Attention is currently required from: flichtenheld.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )

Change subject: Remove ability to use configurations without TLS by default
......................................................................


Patch Set 3:

(6 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/325/comment/8f8747a9_a15b8621 :
PS2, Line 12: line or the configuration itself. This will server as a last and 
final
> "serve"
Done


File doc/man-sections/protocol-options.rst:

http://gerrit.openvpn.net/c/openvpn/+/325/comment/8dd9511d_12101566 :
PS2, Line 237: --secret args
> I think we should at least add a basic documentation for the 
> "allow-deprecated-insecure-static-crypt […]
I am not sure about this. I left it


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/325/comment/d2cedde6_e37b659b :
PS2, Line 618: ,\
> Change trailing comma to full stop.
Done


http://gerrit.openvpn.net/c/openvpn/+/325/comment/a02ba0ac_5ead8aa4 :
PS2, Line 756: secret
> Should be we change the "secret" here?
Done


http://gerrit.openvpn.net/c/openvpn/+/325/comment/f1bbbe12_653561e4 :
PS2, Line 2843:             "OpenVPN 2.7 allow using this configuration when 
using "
> "allows"
Done


http://gerrit.openvpn.net/c/openvpn/+/325/comment/5449a47c_a226efcb :
PS2, Line 2845: configuration
> "proper configuration" => "TLS mode"?
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5
Gerrit-Change-Number: 325
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Comment-Date: Sun, 08 Oct 2023 09:47:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to