Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )
Change subject: Remove ability to use configurations without TLS by default ...................................................................... Patch Set 3: Code-Review+1 (7 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/325/comment/240de6f3_09e6b00f : PS2, Line 12: line or the configuration itself. This will server as a last and final > "serve" Done Patchset: PS3: All my comments were addressed. Need to do another round of review. File doc/man-sections/protocol-options.rst: http://gerrit.openvpn.net/c/openvpn/+/325/comment/59638422_e998b483 : PS2, Line 237: --secret args > I think we should at least add a basic documentation for the > "allow-deprecated-insecure-static-crypt […] Done File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/325/comment/f7e4e3df_016c1f63 : PS2, Line 618: ,\ > Change trailing comma to full stop. Done http://gerrit.openvpn.net/c/openvpn/+/325/comment/93f51a69_84b70446 : PS2, Line 756: secret > Should be we change the "secret" here? Done http://gerrit.openvpn.net/c/openvpn/+/325/comment/9e7b128f_da4157a2 : PS2, Line 2843: "OpenVPN 2.7 allow using this configuration when using " > "allows" Done http://gerrit.openvpn.net/c/openvpn/+/325/comment/4a4aa10d_f2e05c22 : PS2, Line 2845: configuration > "proper configuration" => "TLS mode"? Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/325?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I4f29953b91cf8e8daf2c9503da44073ad96d0ff5 Gerrit-Change-Number: 325 Gerrit-PatchSet: 3 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Comment-Date: Sat, 07 Oct 2023 13:10:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
