Attention is currently required from: cron2, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email )
Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 2: Code-Review-1 (6 comments) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/738f9728_f9eb156f : PS2, Line 427: Adds a an environment variables ``peer_cert_{x}`` (and an alias Remove "a" File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/dd7a5b9a_bf660274 : PS2, Line 466: /* export the certificate itself as pem when the enabled */ missing words? http://gerrit.openvpn.net/c/openvpn/+/466/comment/f487e7c8_793bcb7e : PS2, Line 477: bool ret = true; Can combine with the next line. http://gerrit.openvpn.net/c/openvpn/+/466/comment/2e703085_bdc2ffba : PS2, Line 602: * these variables defined */ can replace repetition of "these variables" with "them" File src/openvpn/ssl_verify_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/74783133_a96d6da5 : PS2, Line 225: * The only way to is directly access the DER encoded raw certificate "to is" -> "is to" http://gerrit.openvpn.net/c/openvpn/+/466/comment/b48e3170_e0e585b4 : PS2, Line 230: * using needing 3 times the space for the base64 and 100 bytes for the drop one of "using needing" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Comment-Date: Wed, 06 Dec 2023 17:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
