Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email )
Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 2: (6 comments) File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/dccfc964_cfd463f3 : PS2, Line 427: Adds a an environment variables ``peer_cert_{x}`` (and an alias > Remove "a" Done File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/2e49f9a9_cc253bc2 : PS2, Line 466: /* export the certificate itself as pem when the enabled */ > missing words? Done http://gerrit.openvpn.net/c/openvpn/+/466/comment/99393580_9e01f59d : PS2, Line 477: bool ret = true; > Can combine with the next line. Done http://gerrit.openvpn.net/c/openvpn/+/466/comment/9626e926_96849b76 : PS2, Line 602: * these variables defined */ > can replace repetition of "these variables" with "them" Done File src/openvpn/ssl_verify_mbedtls.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/32a92534_6ee0a5db : PS2, Line 225: * The only way to is directly access the DER encoded raw certificate > "to is" -> "is to" Done http://gerrit.openvpn.net/c/openvpn/+/466/comment/85213291_05de576e : PS2, Line 230: * using needing 3 times the space for the base64 and 100 bytes for the > drop one of "using needing" Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 2 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Thu, 07 Dec 2023 11:27:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
