Attention is currently required from: cron2, flichtenheld. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/466?usp=email )
Change subject: Implement the --tls-export-cert feature ...................................................................... Patch Set 7: (4 comments) Patchset: PS6: So we have to decide how to go about this. The current patch only So just exporting and providing File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/466/comment/f8e03d25_01b36152 : PS6, Line 426: --tls-export-cert-path dir > the manpage calls the option "tls-export-cert-path", while options. […] Ooops missed that one. File src/openvpn/init.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/e88dae53_952dc331 : PS6, Line 3339: to.export_peer_cert_dir = options->tls_export_peer_cert_path; > why call this "_dir" in the to, and "_path" in options-> ? Fixed and now using always _dir File src/openvpn/ssl_verify.c: http://gerrit.openvpn.net/c/openvpn/+/466/comment/6cb0e20f_1acc6fec : PS6, Line 734: if (opt->export_peer_cert_dir) > So I tried to understand why it seemed to work in my testing. […] This version of the patch now removes the environment variable together with the file. That is not as intrusive and should give at least backwards compatibility for now. The better solution is more complicated and requires modification to env handling (or even lot bigger refactoring) and is moved to follow up patches. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/466?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ia9b3f1813d2d0d492d17c87348b4cebd0bf19ce2 Gerrit-Change-Number: 466 Gerrit-PatchSet: 7 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Tue, 02 Jan 2024 16:45:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
